fix first_samp matching in maxwell_filter_prepare_emptyroom #12755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes mne-tools/mne-bids-pipeline#967
maxwell_filter_prepare_emptyroommatches the ER raw file'sfirst_samp(really_cropped_samp) attribute to that of the raw file from which the headpos data comes. This breaks things if the two files have different sampling frequencies. See mne-tools/mne-bids-pipeline#967 (comment) for more info.Draft because I'm having trouble getting tests to run on the remote machine where I found/fixed(?) this, so IDK yet if the test is actually going to pass.