[MRG] convert some more % strings to fstrings #12758
Conversation
sappelhoff
requested review from
adam2392,
agramfort,
dengemann,
drammock,
jasmainak,
larsoner,
mscheltienne and
wmvanvliet
as code owners
|
I'll try to add a few more later |
|
Still around 150 incidences over 20+ files left. 😬 You can find them by globally searching for |
| CODESPELL_SKIPS ?= "doc/_build,doc/auto_*,*.fif,*.eve,*.gz,*.tgz,*.zip,*.mat,*.stc,*.label,*.w,*.bz2,*.annot,*.sulc,*.log,*.local-copy,*.orig_avg,*.inflated_avg,*.gii,*.pyc,*.doctree,*.pickle,*.inv,*.png,*.edf,*.touch,*.thickness,*.nofix,*.volume,*.defect_borders,*.mgh,lh.*,rh.*,COR-*,FreeSurferColorLUT.txt,*.examples,.xdebug_mris_calc,bad.segments,BadChannels,*.hist,empty_file,*.orig,*.js,*.map,*.ipynb,searchindex.dat,install_mne_c.rst,plot_*.rst,*.rst.txt,c_EULA.rst*,*.html,gdf_encodes.txt,*.svg,references.bib,*.css,*.edf,*.bdf,*.vhdr" | ||
| CODESPELL_DIRS ?= mne/ doc/ tutorials/ examples/ | ||
| all: clean inplace test test-doc | ||
| all: clean test-doc |
There was a problem hiding this comment.
attention: These are non-f-string-related changes ☝️
These targets do not exist in the Makefile and were giving me errors, so I suggest to remove them.
|
@mscheltienne @cbrnr please merge if you are happy with this. I'll fix potential errors that the CI spits out, but I won't be fixing more f-strings ... we'll have to continue with that another time :-) |
sappelhoff
changed the title
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
I only spot checked but looks good to me!
There was a problem hiding this comment.
Spot checked as well, LGTM, marking for merge, thanks @sappelhoff!
3 participants
As far as I can see there are around 300 more fixes in around 80 more files to be done. But many of them cannot safely be done automatically, so here are a few manual fixes that should be fine.