FIX: Properly handle blink interpolation in the case of a cropped raw object #12759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter interpolation function to account for first sample of the raw signal - which allows you to account for if a raw object has been cropped to accurately interpolate the correct periods of data
import required annotations function properly
for more information, see https://pre-commit.ci
scott-huberty
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
larsoner
reviewed
Jul 29, 2024
larsoner
reviewed
Jul 29, 2024
larsoner
approved these changes
Jul 29, 2024
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Marking for merge-when-green, thanks in advance @scott-huberty @schekroud !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12408
closes #12415 (supersedes)
I've just added a test onto #12415 by @schekroud and merged main
EDIT: (I confirmed locally that the updated test will fail on the current main branch, which would be expected).