ENH: check for dropping all channels #12763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farzin-Negahbani
requested review from
agramfort,
dengemann,
jasmainak and
mscheltienne
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
larsoner
reviewed
Jul 31, 2024
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Can you add a doc/changes/12763.bugfix.rst with something like:
Fix check for dropping all channels in :meth:`mne.io.Raw.drop_channels` and related methods, by :newcontrib:`Farzin Negahbani`.
and then add your name + URL to doc/changes/names.inc?
reduce redundant calculation for drop all check Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
drammock
approved these changes
Aug 1, 2024
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Member
|
Thanks @Farzin-Negahbani ! |
Contributor
Author
|
@larsoner, Thank you and all amaizing contributors :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #12762.
What does this implement/fix?
Avoids dropping all channels in an object by raising a ValueError with the message:
All channel(s) would be dropped.