MAINT: Sort names.inc using pre-commit hook
#12765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
agramfort,
dengemann and
drammock
as code owners
Member
Author
|
Also going to push commits for this failing https://app.circleci.com/pipelines/github/mne-tools/mne-python/24815/workflows/55383920-e341-456d-b929-a8ee1c71169f/jobs/67690 |
larsoner
commented
Aug 1, 2024
| # If it's available on PyPI, add it to this set: | ||
| PYPI_PACKAGES = { | ||
| "alphaCSC", | ||
| "conpy", |
Member
Author
There was a problem hiding this comment.
We were linking to the wrong conpy (whoops!)
drammock
approved these changes
Aug 2, 2024
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
LGTM, just one question (hopefully not a dumb one; reviewing on a phone)
| # directories to ignore when looking for source files. | ||
| # This pattern also affects html_static_path and html_extra_path. | ||
|
|
||
| # NB: changes here should also be made to the linkcheck target in the Makefile |
Member
There was a problem hiding this comment.
Why do we want linkcheck to ignore our _includes folder? Isn't there valid rST in there that might contain links?
Member
Author
There was a problem hiding this comment.
Yes but it gets .. include::ed somewhere else. If you don't exclude it then you get hundreds of warnings about duplicated link names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help us keep it sorted. Also gets in a CircleCI fix. Another option would have been to do
in the
autofix.cijob. But pre-commit hook seemed cleaner.