Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Aug 2, 2024

Closes #12768

Transitioned some testing and datasets code to pathlib.Path while I was in there tinkering anyway.

@larsoner larsoner added this to the 1.8 milestone Aug 2, 2024
@drammock
Copy link
Member

drammock commented Aug 2, 2024

test needs an os.sep somewhere. TLDR fsaverage/label != fsaverage\\label:

mne\datasets\tests\test_datasets.py:91: in test_datasets_basic
    assert sd_label_str == str(sd_2 / "label")
E   AssertionError: assert 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_datasets_basic0\\mne_data\\MNE-fsaverage-data\\fsaverage/label' == 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-runneradmin\\pytest-0\\test_datasets_basic0\\mne_data\\MNE-fsaverage-data\\fsaverage\\label'

@hoechenberger hoechenberger merged commit e42e1d6 into mne-tools:main Aug 4, 2024
@hoechenberger
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should fetch_fsaverage() return a Path?

3 participants