-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix HTML repr table rendering #12788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
here's what the repr HTML tables look like on built docs: The buttons for showing bad channels are a bit wonky; I'll have to work on that. Pushing commits now that make it look ok in Jupyter notebook. I tried tackling VSCode interactive pane too... but the whole notebook gets hidden in an |
|
@drammock I marked for 1.8, this is probably a blocker right? |
could also just backport it afterwards I guess? I will try to finish today but can't promise it. |
|
Yeah backporting seems okay! |
|
Aren't the carets in Jupyter and VS Code swapped between "opened" and "collapsed" state? |
|
just want to add, i think this is a great job, @drammock |
oops yes, good catch. |
|
@hoechenberger @larsoner this one is ready! |
|
I looked at the examples and reports and they look great, thanks @drammock ! |






closes #12775
WIP because I haven't addressed appearance in notebooks or IDEs yet. But in the meantime at least y'all can see how it looks in the built docs, and offer feedback.