Skip to content

Conversation

@drammock
Copy link
Member

closes #12775

WIP because I haven't addressed appearance in notebooks or IDEs yet. But in the meantime at least y'all can see how it looks in the built docs, and offer feedback.

@drammock
Copy link
Member Author

here's what the repr HTML tables look like on built docs:

https://output.circle-artifacts.com/output/job/df0a833c-b387-4034-a9e4-f3d59d80ef3f/artifacts/0/html/auto_tutorials/raw/20_event_arrays.html#sphx-glr-auto-tutorials-raw-20-event-arrays-py

The buttons for showing bad channels are a bit wonky; I'll have to work on that. Pushing commits now that make it look ok in Jupyter notebook. I tried tackling VSCode interactive pane too... but the whole notebook gets hidden in an iframe and I can't seem to access the individual DOM elements in the notebook output cells via the built-in developer tools pane... maybe @hoechenberger can point me in the right direction (or just push some commits).

@larsoner larsoner added this to the 1.8 milestone Aug 14, 2024
@larsoner
Copy link
Member

@drammock I marked for 1.8, this is probably a blocker right?

@drammock
Copy link
Member Author

@drammock I marked for 1.8, this is probably a blocker right?

could also just backport it afterwards I guess? I will try to finish today but can't promise it.

@larsoner
Copy link
Member

Yeah backporting seems okay!

@larsoner larsoner modified the milestones: 1.8, 1.9 Aug 14, 2024
@drammock drammock marked this pull request as ready for review August 14, 2024 21:18
@drammock
Copy link
Member Author

drammock commented Aug 14, 2024

OK here are some screenshots (hover effect does work in Jupyter light mode, I must have just wiggled the mouse when screenshotting):

Sphinx

built-docs-dark

built-docs

Jupyter

juypter-dark

jupyter-light

VSCode

vscode-dark

vscode-light

@hoechenberger
Copy link
Member

Aren't the carets in Jupyter and VS Code swapped between "opened" and "collapsed" state?

@hoechenberger
Copy link
Member

hoechenberger commented Aug 15, 2024

just want to add, i think this is a great job, @drammock
I'm currently on a hiking trip in the mountains with limited internet access (and only through my phone), so cannot really test or provide thorough feedback until next week or so

@drammock
Copy link
Member Author

Aren't the carets in Jupyter and VS Code swapped between "opened" and "collapsed" state?

oops yes, good catch.

@drammock drammock marked this pull request as draft August 15, 2024 15:37
@drammock drammock marked this pull request as ready for review September 20, 2024 20:34
@drammock
Copy link
Member Author

@hoechenberger @larsoner this one is ready!

@larsoner
Copy link
Member

I looked at the examples and reports and they look great, thanks @drammock !

@larsoner larsoner merged commit dcb05a2 into mne-tools:main Sep 23, 2024
@drammock drammock deleted the tables branch October 25, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTML repr tables have really bad text contrast ratios

3 participants