Skip to content

[API] Deprecate average parameter from CSP and SPoC plotting methods #12829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 2 commits into from
Sep 6, 2024
Merged

[API] Deprecate average parameter from CSP and SPoC plotting methods #12829

larsoner merged 2 commits into from
Sep 6, 2024

Conversation

@tsbinns
Copy link
Contributor

@tsbinns tsbinns commented Sep 5, 2024 •
edited by larsoner
Loading

Reference issue

Closes #12665.

What does this implement/fix?

In the plot_filters and plot_patterns methods used by the CSP and SPoC classes, adds a FutureWarning for the average parameter that it will be removed in v1.10.

Additional information

Currently in the tests, average isn't called anywhere. Should I add a new test for the FutureWarning?

@tsbinns tsbinns requested a review from jasmainak as a code owner September 5, 2024 15:47
@larsoner
Copy link
Member

larsoner commented Sep 6, 2024

Currently in the tests, average isn't called anywhere. Should I add a new test for the FutureWarning?

No need I think and failures are unrelated so in it goes, thanks @tsbinns !

@larsoner larsoner merged commit c993ae5 into mne-tools:main Sep 6, 2024
@tsbinns tsbinns deleted the deprecate_average branch September 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasmainak jasmainak Awaiting requested review from jasmainak jasmainak is a code owner

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@drammock drammock Awaiting requested review from drammock drammock is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove average parameter from CSP and SPoC plotting methods

2 participants

@tsbinns @larsoner