Add update to .elc montage reader
#12830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
agramfort,
dengemann,
drammock,
jasmainak,
larsoner and
mscheltienne
as code owners
for more information, see https://pre-commit.ci
Member
Author
|
@larsoner I think the test failures are unrelated. This is ready to be merged from my side. |
Member
|
Agreed, thanks @sappelhoff ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I add some code so that
read_custom_montagemay also read newer style.elcfiles. This is consistent with tests files I have locally, as well as code in fieldtrip and discussions on the EEGLAB mailing list:xrefs: