-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MAINT: Remove BaseEstimator #12834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Remove BaseEstimator #12834
Conversation
drammock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! changes look reasonable / straightforward, so I'm inclined to trust our test suite here. Just one question.
mne/decoding/ssd.py
Outdated
| @property | ||
| def picks_(self): | ||
| """Backward compatible wrapper for picks.""" | ||
| return self.picks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to deprecate .picks_ or just keep it around forever?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pretty trivial to keep it I think so probably not worth deprecating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
|
thanks for working on this, Eric! |
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some discussion on picks_ vs picks
if sklearn becomes just required in mne.decoding and not any mne import I am ok with that. We do have a CI run without sklearn?
mne/decoding/ssd.py
Outdated
| @property | ||
| def picks_(self): | ||
| """Backward compatible wrapper for picks.""" | ||
| return self.picks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
Yep the |
|
Got approval and latest commits were just getting things green so in it goes! |
Closes #12748
sklearnstuff inmne/decodingexcept places that we use private attributes. Someday maybe we shouldn't use them at all, but I'll save that for later. In the meantime I'd rather not break all ofmne.decodingif any of those imports fail in the future.check_arraynow that we require sklearn >= 1.2 (it's available as of 1.1)covstuff didn't end up being too terrible -- just had to write a little helper forget_params/set_params