[MRG] Remove impedances in ant reader in favor of an example using antio #12868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscheltienne
requested review from
agramfort,
dengemann and
drammock
as code owners
mscheltienne
commented
Sep 23, 2024
larsoner
reviewed
Sep 23, 2024
Comment on lines
4
to
5
| ====================================== | ||
| Getting impedances from ANT Neuro .cnt |
Member
There was a problem hiding this comment.
For future compat and not needing to add redirects etc. could we rename this "Getting impedances from different EEG formats" or something, and then have a section with antio, then a short section for BrainVision that trivially shows raw.impedances? The latter would really just be a placeholder for when we soon show how to do it with pybv.
drammock
approved these changes
Sep 23, 2024
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
just some slight wordsmithing; otherwise looks great!
Co-authored-by: Daniel McCloy <dan@mccloy.info>
This reverts commit 7ac3c51.
mscheltienne
commented
Sep 24, 2024
| ] | ||
| "examples/*/*.py" = [ | ||
| "D205", # 1 blank line required between summary line and description | ||
| "D400", # First line should end with a period |
Member
Author
There was a problem hiding this comment.
I added and exception for D400 in tutorials and examples, as the first line is usually something like:
"""
.. _ex-sensitivity-maps:
================================================
Display sensitivity maps for EEG and MEG sensors
================================================
[...]
Member
|
Thanks @mscheltienne ! |
larsoner
added a commit
to mscheltienne/mne-python
that referenced
this pull request
Sep 24, 2024
* upstream/main: Add support for dictionary-type `ref_channels` in `set_eeg_reference()` (mne-tools#12366) [MRG] Remove impedances in ant reader in favor of an example using antio (mne-tools#12868) [pre-commit.ci] pre-commit autoupdate (mne-tools#12869)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed here #12861
We could remove the
raw._impedancesnon-standard attribute fromantand other readers (e.g.bv) in favor of an example which showcases how to get this information if needed.