ENH: Better validation of info and subject_info #12875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
agramfort,
dengemann and
drammock
as code owners
drammock
reviewed
Sep 26, 2024
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it wasn't too hard to generalize the nice validation set up originally by @mscheltienne using a
ValidatedDictclass. In principle yes this could be done with something likepydanticbut this would require a separate new dependency (which is a high bar for us) so this PR just refactors and reuses the existingInfologic instead.Closes #12874