Skip to content

dedent #12925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 1 commit into from
Oct 29, 2024
Merged

dedent #12925

larsoner merged 1 commit into from
Oct 29, 2024

Conversation

@drammock
Copy link
Member

@drammock drammock commented Oct 29, 2024

fixes #12921

Would appreciate an extra set of eyes, I'm pretty sure this change preserves the intent, but the safe_event decorator has me a bit unsure.

@drammock drammock requested a review from dengemann as a code owner October 29, 2024 15:13
@larsoner
Copy link
Member

larsoner commented Oct 29, 2024

The safe_event is actually meant to be smart about swallowing exceptions. The break indeed looks like it's at the wrong level

@larsoner larsoner enabled auto-merge (squash) October 29, 2024 15:49
@larsoner larsoner merged commit 98d55b4 into mne-tools:main Oct 29, 2024
@drammock drammock deleted the fix-break branch October 29, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees

No one assigned

Labels

no-changelog-entry-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

break in finally swallows exceptions

2 participants

@drammock @larsoner