Skip to content

Fix unit handling for µV and parsing of birthday in ANT format #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscheltienne merged 3 commits into from
Oct 31, 2024
Merged

Fix unit handling for µV and parsing of birthday in ANT format #12933

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4794a0e
fix parsing of subject info
mscheltienne Oct 31, 2024
bb0da81
improve unit handling
mscheltienne Oct 31, 2024
4b8e93e
fix
mscheltienne Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mne/io/ant/ant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

from numpy.typing import NDArray

units = {"uv": 1e-6}
_UNITS: dict[str, float] = {"uv": 1e-6, "µv": 1e-6}


@fill_doc
Expand Down Expand Up @@ -143,8 +143,12 @@ def __init__(
info["device_info"] = dict(type=make, model=model, serial=serial, site=site)
his_id, name, sex, birthday = read_subject_info(cnt)
info["subject_info"] = dict(
his_id=his_id, first_name=name, sex=sex, birthday=birthday
his_id=his_id,
first_name=name,
sex=sex,
)
if birthday is not None:
info["subject_info"]["birthday"] = birthday
if bipolars is not None:
with info._unlock():
for idx in bipolars_idx:
Expand Down Expand Up @@ -294,8 +298,8 @@ def _scale_data(data: NDArray[np.float64], ch_units: list[str]) -> None:
for idx, unit in enumerate(ch_units):
units_index[unit].append(idx)
for unit, value in units_index.items():
if unit in units:
data[np.array(value, dtype=np.int16), :] *= units[unit]
if unit in _UNITS:
data[np.array(value, dtype=np.int16), :] *= _UNITS[unit]
else:
warn(
f"Unit {unit} not recognized, not scaling. Please report the unit on "
Expand Down