Some additions to the dipole orientation tutorial. #12960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
requested review from
agramfort,
dengemann and
drammock
as code owners
larsoner
reviewed
Nov 12, 2024
|
|
||
| .. warning:: | ||
| A common "gotcha!" is that by default, dipole orientation information is discarded | ||
| in the source estimate. Only the magnitude of the activity is retained. This means |
Member
There was a problem hiding this comment.
I think this is true when using loose != 0. For fixed ori I think it stays signed even with pick_ori=None (the default). But given that loose="auto" defaults to 0.2 even for surfaces I think it's okay to delve into these details elsewhere. Thanks @wmvanvliet !
Contributor
Author
There was a problem hiding this comment.
You are correct :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a discussion on the forum, it may be a good idea to mention these common gotchas/pitfalls when doing analyses in source space. Because we pool activity across dipoles by default, source activity is always positive. Hence, don't expect sine waves to remain sine waves, don't expect averaging across multiple epochs to produce a nice evoked response (noise cancelling out).
Also, some of the figures needed some fixes to render properly.