Skip to content

Conversation

@cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Nov 13, 2024

Fixes #12961.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbrnr
Copy link
Contributor Author

cbrnr commented Nov 13, 2024

Yes, but then we have to switch to base 1000, because currently we are using base 1024 (e.g. 1 kB = 1000 bytes, but 1 kiB = 1024 bytes). I'm fine either way.

@drammock
Copy link
Member

This was discussed before in regards to the sys_info output and we settled on GiB so let's be consistent and stick with that here.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one capitalization fix in the changelog entry

Co-authored-by: Daniel McCloy <dan@mccloy.info>
@cbrnr
Copy link
Contributor Author

cbrnr commented Nov 14, 2024

I'll fix the tests this afternoon!

@cbrnr
Copy link
Contributor Author

cbrnr commented Nov 14, 2024

I will definitely never understand Sphinx, so I'd be happy if someone fixed this reference not found issue for me. Thanks!

@larsoner larsoner enabled auto-merge (squash) November 14, 2024 16:08
@larsoner larsoner merged commit 1e7cef1 into mne-tools:main Nov 14, 2024
@cbrnr cbrnr deleted the sizeof_fmt branch November 15, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Units in mne.utils.sizeof_fmt() incorrect

4 participants