fix circleci build #12990
Closed
fix circleci build #12990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
requested review from
agramfort,
dengemann and
larsoner
as code owners
larsoner
reviewed
Nov 26, 2024
| wait = WebDriverWait(driver, 20) | ||
| wait.until(lambda d: d.find_element(by=By.ID, value="contributor-avatars")) | ||
| body = driver.find_element(by=By.TAG_NAME, value="body").get_attribute( | ||
| body = driver.find_element(by=By.TAG_NAME, value="body").get_dom_attribute( |
Member
There was a problem hiding this comment.
I think this actually isn't correct. When I used it it returned None locally at least. So I went with get_property in https://github.com/mne-tools/mne-python/pull/12988/files#diff-e37d44d56ea2e365f274d4ef509351df9bc6a94674d1617972f63063484012ddR37 / #12988 (comment)
Member
There was a problem hiding this comment.
... but maybe I did it wrong, I didn't look at the output yet...
Member
Author
There was a problem hiding this comment.
ah OK. I was just going by the deprecation message and hoping it would work, planning to follow-up if it didn't. But if you're already addressing elsewhere I'll close this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a deprecation warning in selenium that crops up in our full doc build
https://app.circleci.com/pipelines/github/mne-tools/mne-python/25844/workflows/8910d23f-2373-43a6-8717-e15a9197aeba/jobs/69854