BUG: Fix GDF Out of Bound Error #13113
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
greasycat
changed the title
greasycat
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
scott-huberty
requested changes
Feb 12, 2025
Co-authored-by: Scott Huberty <52462026+scott-huberty@users.noreply.github.com>
for more information, see https://pre-commit.ci
Contributor
larsoner
approved these changes
Feb 13, 2025
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Marking for merge-when-green and restarting the spuriously failed CI, thanks in advance @greasycat !
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Fixes #13111.
What does this implement/fix?
This fixes a "Python integer 512 out of bounds" issue that occurred when accumulating values using a for-loop with exponentiation (2 ** (i * 8)) in a GDF parsing function. The issue arose because intermediate values exceeded the uint8 (0-255) limit.
Related Fix: #12909