Skip to content

Conversation

@drammock
Copy link
Member

@drammock drammock commented Mar 4, 2025

This PR:

  • puts an rST table caption all on one line, which fixes an irregularity in how mkdocs parses the objects.inv file. This will enable intersphinx-like xrefs from the MNE-BIDS-Pipeline docs into MNE-Python docs. needed for intersphinx mne-bids-pipeline#1066

unrelated tweaks, since I was mucking in that file already:

  • removes trailing periods from a couple table captions
  • utilizes the preferred docutils :name: syntax for defining tables as xref targets

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will manually merge once CircleCI comes back happy without waiting for the other CIs

@larsoner larsoner merged commit 73c4a7c into mne-tools:main Mar 4, 2025
24 of 31 checks passed
@larsoner
Copy link
Member

larsoner commented Mar 4, 2025

Thanks @drammock !

@drammock drammock deleted the fix-intersphinx branch March 4, 2025 16:51
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 4, 2025
* upstream/main: (149 commits)
  FIX make_watershed_bem to handle missing talairach_with_skull.lta courtesy Freesurfer 8 (mne-tools#13172)
  ENH: Add upsampling for MEG helmet surface (mne-tools#13179)
  MAINT: Update code credit (mne-tools#13180)
  BUG: Fix bug with least-squares sphere fit (mne-tools#13178)
  fix EDF export (mne-tools#13174)
  fix typo (mne-tools#13171)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13164)
  Fix dev installation guide (mne-tools#13163)
  expose 'mode' for plotting dipole on brain (mne-tools#13162)
  turn dipole attrs into properties (mne-tools#13153)
  remove misformatted (and unused) crossref anchor (mne-tools#13155)
  doc: point to read_dipole (mne-tools#13149)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13152)
  BUG: Fix bug with not short-circuiting n_jobs=1 (mne-tools#13147)
  FIX: Missing coordinates.xml in MFF file (mne-tools#13148)
  FIX: Gracefully handle bad XML files in EGI reader (mne-tools#13145)
  Fixes for Latest IPython (9.0.1) (mne-tools#13146)
  Fix intersphinx (mne-tools#13143)
  BUG: Fix bug with parallel doc build (mne-tools#13140)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13141)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants