Use __setattr__ to set PolyData._hemi dynamically
#13329
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream as part of pyvista/pyvista#7716, setting dynamic attributes on meshes will no longer be allowed. MNE currently adds a
_hemiattribute dynamically, which is causing integration test failures:https://github.com/pyvista/pyvista/actions/runs/16335129476/job/46145621314?pr=7716#step:15:2380
I'm pretty sure they'll all be resolved by this PR with this change.
There will be a global flag as part of the API to allow setting dynamic attributes, but pending review/approval of pyvista/pyvista#7716, I'm pretty this will be off by default. Until a release is made with the "official" flag/mechanism for enabling this, a workaround for this restriction is to use
object.__setattr__.