MRG: EEG Reference, now also in Epochs and Evoked #1733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a base function 'apply_reference' that can apply various different referencing schemes. Two convenience functions are also added that provide a convenient interface to the base function: - set_eeg_reference: apply a simple reference to all EEG channels - set_bipolar_reference: apply a bipolar reference (or more)
Raw and Epoch classes will no longer add an average reference if the `custom_ref_applied` flag was set. SSP projections will still attempt this, but a new assertion in `make_eeg_average_ref_proj` will raise an error if the flag was set. Before a CAR projection is added, the `info['custom_ref_applied']` flag is checked.
- Also check for duplicate channel names - Bilpolar channels can be named after the anode/cathode - Inform user of the chosen bipolar channel name
Any existing SSP operators that are inactive and touch sensors used in the referencing scheme will be applied.
wmvanvliet
changed the title
Contributor
Author
|
@dengemann can you give this a try? The referencing function can now also take an Epochs or Evoked object as parameter. |
examples/plot_rereference_eeg.py
Outdated
Member
There was a problem hiding this comment.
leave one line empty below for readanility
Member
|
@wmvanvliet feel free to merge after having addressed my comments. Good work! |
Member
|
Please rebase and check Travis before merging, this will ensure docstrings are automatically checked (recent PR merge). |
Contributor
Author
|
can I press the green button now? |
Member
|
The honor is yours @wmvanvliet :) |
wmvanvliet
added a commit
that referenced
this pull request
Jan 7, 2015
MRG: EEG Reference, now also in Epochs and Evoked
Member
|
Thanks for this nice contrib @wmvanvliet! And als for enduring the review sprint and all my nit-picky inputs. |
Member
|
thanks @wmvanvliet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation from #1713