MRG Layout remake

[jaeilepp]

Though it turned out not to be the mess I expected, I decided to make a separate PR for this. This here would also be a good opportunity to design the layout so that it looks good. Now the layout uses pixels instead of inches so in theory it should work on all screen sizes and platforms.
Should there be a 'help' button somewhere that would open a pop up window to view all the key combinations etc. (discussed in #2206)? Are there other buttons we might need?

[agramfort]

start with help button. and please share screenshots.

[jaeilepp]

The point of the remake was to make it so that it looks the same on all platforms. The actual look of the layout shouldn't have changed much (apart from the title being larger). So the idea to make this a separate PR was to test this on all platforms and see if it turns out ok. I can test this on virtual box on my laptop (which has really weird screen settings) once I get home.

[agramfort]

ok cool no time to test though

[mainakjas]

by the way, one small issue I noticed with the raw plotter. If I select the bad channel, then the channel name doesn't get grayed out so it's a bit hard to say which channel got selected. @jaeilepp can you squeeze this into one of your PRs or make a new PR to address this. Should be an easy fix ...

[larsoner]

One problem is that having a non-standard DPI will break the rendering:

You can set the figure.dpi param in matplotlibrc if you want to try it yourself, or do the equivalent in Python space with rcParams or whatever it is called. Not sure if there is an easy fix. Not the end of the world if there isn't.

For me the "+", "-", and "b" keys don't work, even though pageup/pagedown/home/end do. This makes sense given that they aren't listed in _plot_onkey in mne/viz/epochs.py, are you still working on adding those?

[larsoner]

Also, 'escape' should close the epochs browsing window like it does for raw, and it should be added to the help.

[agramfort]

indent pb

[agramfort]

you'll need to rebase too.

[jaeilepp]

I guess it's best to finish the butterfly and continue with this when it's merged.

[agramfort]

sounds good

[jaeilepp]

Update:
Added a dialog for adjusting the number of epochs/channels per view as suggested in #2213.

[teonbrooks]

this was missed in the last pr: could you a command line message to remind/notify the user of the drop channel similar to the drop epochs message. would be very useful.

[jaeilepp]

Well the channels aren't actually dropped. They're just added to the bads list like in raw.plot.

[teonbrooks]

@mainakjas, @yousrabk, and I were discussing having an interactive way of selecting channels. In my system acquisition software we have plot of the channel montage and you can select a set of sensors this way. we could also include some buttons for pre-defined ROIs, like the ones given in mne_browse_raw (temporal, occipital quadrants, etc.)

here's a screen capture of the window:

[teonbrooks]

sorry, yeah, a message to notify which channels are marked in info['bads']

[jaeilepp]

There is already an 'order' param in plot_raw that allows the user to define the order of the shown channels. Don't know if it's used much.

[mainakjas]

In the help, can you align all the colons ? And color the keyboard shortcut red / yellow or make it bold. See whatever looks good. Just some aesthetics to make it look professional :)

[mainakjas]

More help dialog related comments:

• put + and = on the same line separated by the word 'or`
• can you use the unicode to show the arrow keys: https://en.wikipedia.org/wiki/Arrow_%28symbol%29 ?
• close mne_browse_epochs -> Quit
• f11 -> F11 (make the f capital)

[mainakjas]

Some comments about the viewport dialog box

• the title of the dialog box is not inclusive of the check boxes
• the checkboxes update immediately in the plot but the viewport dimensions don't update until you press the update button. Can you make it consistent? Actually, it would be better to have no update button if possible.
• T0 visible => zeroline
• Y labels visible => channel names

Should we also have a checkbox for event-id and epoch-id for consistency?

[mainakjas]

In the help dialog, can you right justify the bold stuff (like here for example: https://inkscape.org/en/doc/keys046.html). Also can we change the sentences at the bottom to look like the table of keyboard shortcuts? Something like:

click epoch -> mark bad epoch
click channel -> mark bad channel
right click -> vertical line at a time instant
middle click -> show channel name (butterfly plot)

Maybe put a small heading which says mouse controls or something like that?

[agramfort]

Screen shot ?

[jaeilepp]

the checkboxes update immediately in the plot but the viewport dimensions don't update until you press the update button. Can you make it consistent? Actually, it would be better to have no update button if possible.

This is a usability thing. If you change the viewport dimensions, it takes a while to update, which is not the case with the labels and vertical lines. Imagine trying to adjust the viewport to show every epoch and channel and not hitting the end of the slider immediately.

[jaeilepp]

[jaeilepp]

Done.

[agramfort]

:) :)

[agramfort]

clean up and I'll merge.

[jaeilepp]

Oops. Done.

[agramfort]

missing empty line

[agramfort]

Tell me travis is happy. I'll merge.

[jaeilepp]

Oops again. There was an empty line at the end it just doesn't show it here and I didn't notice it either.

[jaeilepp]

Okay, travis is happy.

[agramfort]

Thanks !