-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[MRG] EOG and ECG channels added to the bottom of ICA plot. #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
looks clean to me! I see a bit of code reduplication. Maybe worth a small function. Other than that do you thinki we should add a test? |
|
is this a MRG PR? |
mne/viz/ica.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the defaults._handle_default
|
Ready for merge? |
|
not yet... why is this not captured by tests? |
|
works like a charm. thanks @jaeilepp ! |
[MRG] EOG and ECG channels added to the bottom of ICA plot.
Proposed at #2251.
