-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: Faster raw resampling #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@choldgraf this one should make you happy :) |
|
Super cool. IIRC some of the TF decomposition methods could also benefit from auto padding to powers of 2? |
| sfreq : float | ||
| New sample rate to use. | ||
| npad : int | ||
| npad : int | str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad got it... forget it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, None is only for deprecation purposes (not meant to be used)
|
LGTM @choldgraf if you can give it a try to confirms if works for you it's great |
|
@agramfort why wait when we can confirm: Yields: So the gains will depend on the inputs and resulting sizes, but sometimes the speed gains can be drastic. |
|
:D resampling speed! I ran it on a dataset that I've got, here's the output: Nice :) |
|
nice :) |
|
😍 |
|
I'll go ahead and merge since I need this for #2977, but if anyone else has comments on the code feel free and I'll follow up |
|
This one is so good to have happened. |


This PR:
npad='auto'mode that will set the pad to the shortest pad >= 100 samples that will result in a signal length that is a power of 2.npad=100default to have'auto'become default in 0.12rfftandirfftfor computations.This means:
Ready for review/merge from my end.
Closes #2035.