Skip to content

Conversation

@choldgraf
Copy link
Contributor

This is a quick extension of #3198. I realized that the function would only pull eeg or meg channels when computing the auto-scaling, but we probably want auto-scaling to work for any channel types. This should add support for the remaining channel types.

@coveralls
Copy link

coveralls commented May 8, 2016

Coverage Status

Coverage increased (+0.004%) to 90.857% when pulling a18814e on choldgraf:add_ch_types_auto_scale into 5a71c71 on mne-tools:master.

@choldgraf choldgraf force-pushed the add_ch_types_auto_scale branch from a18814e to 4001e25 Compare May 8, 2016 17:26
@choldgraf choldgraf force-pushed the add_ch_types_auto_scale branch from 4001e25 to 7ae9baa Compare May 8, 2016 17:26
@choldgraf
Copy link
Contributor Author

oops, discovered the channel_indices_by_type after I first pushed this. I think that's probably what we should be using. Cuts back on extra imports and I think simplifies the code a bit. That look OK?

@coveralls
Copy link

coveralls commented May 8, 2016

Coverage Status

Coverage increased (+0.001%) to 90.855% when pulling 7ae9baa on choldgraf:add_ch_types_auto_scale into 5a71c71 on mne-tools:master.

@coveralls
Copy link

coveralls commented May 8, 2016

Coverage Status

Coverage increased (+0.001%) to 90.855% when pulling 7ae9baa on choldgraf:add_ch_types_auto_scale into 5a71c71 on mne-tools:master.

@larsoner larsoner merged commit ee8ac19 into mne-tools:master May 9, 2016
@larsoner
Copy link
Member

larsoner commented May 9, 2016

Thanks @choldgraf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants