[MRG+1] Draggable colorbar. #3290

jaeilepp · 2016-06-08T09:33:40Z

Closes #3005
Also:
closes #3063

agramfort · 2016-06-08T09:37:07Z

mne/time_frequency/tfr.py

        if 'grad' in self:
-            types.append('grad')
+            chs = [ch for ch in self.ch_names if ch.startswith('MEG') and
+                   ch.endswith(('2', '3'))]


this is neuromag specificity. Why is this needed?

Related to #3063
I'll fix it.

kingjr · 2016-06-08T11:27:28Z

Thanks @jaeilepp for taking the time to do this !

From what I understand this would work for divergent colormaps.

Are you planning on addressing the sequential cases (e.g. combined gradiometers, potentially time frequency spectrum)?

In matplotlib they typically use one mouse button for displacement and another for scaling, so we could have a similar approach for clim WDYT?

jaeilepp · 2016-06-08T12:11:38Z

Now the color map can be changed with up/down keys. Clicking and dragging changes the scale. Left mouse button moves it up and down and right mouse button changes the lims.
It was pretty straightforward to implement using the DraggableColorbar in http://www.ster.kuleuven.be/~pieterd/python/html/plotting/interactive_colorbar.html

codecov-io · 2016-06-08T12:31:01Z

Current coverage is 86.67%

Merging #3290 into master will increase coverage by 0.20%

@@             master      #3290   diff @@
==========================================
  Files           335        335          
  Lines         57322      57625   +303   
  Methods           0          0          
  Messages          0          0          
  Branches       8715       8780    +65   
==========================================
+ Hits          49567      49947   +380   
+ Misses         5132       5003   -129   
- Partials       2623       2675    +52

Powered by Codecov. Last updated by ea83b84...5bf1674

kingjr · 2016-06-08T12:46:21Z

mne/viz/topo.py

+        cmap = 'RdBu_r'
+        interactive_cmap = True
+    else:
+        interactive_cmap = False


interactive_cmap = False if cmap == 'interactive': cmap = 'RdBu_r' interactive_cmap = True

kingjr · 2016-06-08T12:48:46Z

LGTM

jaeilepp · 2016-06-09T13:32:12Z

Now interactive mode works for tfr, images and topomaps. For topos it is probably too heavy. Ready for review.

larsoner · 2016-06-10T12:02:55Z

Can you rebase? Then I'll try it and merge if it's all good

larsoner · 2016-06-10T12:45:30Z

doc/whats_new.rst


    - Added the ability to decimate :class:`mne.Evoked` objects with :func:`mne.Evoked.decimate` by `Eric Larson`_

+    - Add 'cmap=interactive' option to plotting functions by `Jaakko Leppakangas`_


double-backticks on the quote will read nicer, and interactive should probably be a string in that code bit

larsoner · 2016-06-10T12:52:36Z

Can you mention quickly the examples you've been running to test this to save reviewers some git grep calls?

jaeilepp · 2016-06-10T13:11:54Z

Can you mention quickly the examples you've been running to test this to save reviewers some git grep calls?

I've had my own scripts for testing, but it works for tfr, topomap and image. So plot_evoked_topomap, plot_channel_epochs_image.py, plot_time_frequency_simulated.py

larsoner · 2016-06-10T13:30:45Z

Does plot_evoked_topomap work for you? It seems really slow for me

larsoner · 2016-06-10T13:31:59Z

For topos it is probably too heavy.

I think we should probably remove the option if it isn't really usable. At the very least we should add a .. warning:: that it's likely very slow.

larsoner · 2016-06-10T13:35:29Z

Works nicely in plot_visualize_evoked.py using a evoked_r_aud.plot_image(picks=picks, cmap='interactive') call. I expected the scroll wheel to do the same thing as the right-click-drag, namely "zoom" the colorbar. WDYT?

jaeilepp · 2016-06-10T13:35:54Z

Does plot_evoked_topomap work for you? It seems really slow for me

Yeah, it's quite slow. I'll investigate.

I think we should probably remove the option if it isn't really usable. At the very least we should add a .. warning:: that it's likely very slow.

It's not enabled for topographies

jaeilepp · 2016-06-10T13:36:27Z

Works nicely in plot_visualize_evoked.py using a evoked_r_aud.plot_image(picks=picks, cmap='interactive') call. I expected the scroll wheel to do the same thing as the right-click-drag, namely "zoom" the colorbar. WDYT?

Yeah, why not.

larsoner · 2016-06-10T13:37:47Z

It's not enabled for topographies

Sorry, I meant for topomap plots even, if we can't make them fast enough to actually use.

jaeilepp · 2016-06-14T08:22:41Z

Now cmap is accepted as tuple, where the second element defines the interacitivity. It is also on by default except with topomaps when there are more than two of them.

… Tests.

larsoner · 2016-06-28T13:50:21Z

LGTM and the interaction is nice in e.g. plot_channel_epochs_image.py. +1 for merge from me.

If someone else has you make changes, it might be nice to add cmap='interactive' in that example or some other one.

dengemann · 2016-06-28T21:08:29Z

Very nice! Indeed. +1 for showing this in one example or even a gif to be tweeted cc @kingjr

jaeilepp · 2016-06-29T07:43:38Z

If someone else has you make changes, it might be nice to add cmap='interactive' in that example or some other one.

That's basically the default behavior now, but I'll add it somewhere since I'm adding a test anyway.

agramfort · 2016-06-29T07:43:54Z

@jaeilepp can you just update the viz tutorial(s) to document this?

then +1 for merge

agramfort · 2016-06-29T07:45:21Z

you can add a section of changing the colormap eg in the epochs viz tutorial

jaeilepp · 2016-06-29T13:17:28Z

Ready for review/merge.

larsoner · 2016-06-29T14:28:53Z

Thanks @jaeilepp

agramfort reviewed Jun 8, 2016
View reviewed changes

jaeilepp changed the title ~~Draggable colorbar.~~ [WIP] Draggable colorbar. Jun 8, 2016

kingjr reviewed Jun 8, 2016
View reviewed changes

jaeilepp force-pushed the draggable-cmap branch from 558938f to 6950997 Compare June 9, 2016 09:54

jaeilepp changed the title ~~[WIP] Draggable colorbar.~~ [MRG] Draggable colorbar. Jun 9, 2016

jaeilepp force-pushed the draggable-cmap branch from 24306c7 to aaa9380 Compare June 10, 2016 12:17

larsoner reviewed Jun 10, 2016
View reviewed changes

jaeilepp force-pushed the draggable-cmap branch from a8b93f8 to 7ab0176 Compare June 14, 2016 08:17

jaeilepp added 18 commits June 28, 2016 15:34

Draggable colorbar.

bff866a

Interactive cmap for topomap. Fixes. Docs.

7c32d1c

Tests. Docs. Fixes.

4e74965

Fix tests.

3aed697

Interactive colorbars to evoked and epochs images. Updated whats_new.…

68e28b8

… Tests.

Fix. Refactoring.

87ded29

Fixes. Refactoring. Scroll event.

9a382f8

block=False for topomap animation.

027d644

Interactive mode on by default. Space bar resets scale.

23dab5f

Updated tests.

3aef586

Allow cmap=interactive.

4d79cff

Fixes.

23a7f99

Small fix.

7eb6368

Interactive cbar for some functions. Docs. Bug fixes.

b6ee141

Coverage.

eaa5156

More coverage.

e75c9e6

Fix.

8262410

Refactoring.

696721d

larsoner changed the title ~~[MRG] Draggable colorbar.~~ [MRG+1] Draggable colorbar. Jun 28, 2016

jaeilepp mentioned this pull request Jun 29, 2016

fix vmin vmax in plot_epochs_image when picks is more than one #3359

Closed

Modified test and tutorial.

5bf1674

larsoner merged commit a3ed105 into mne-tools:master Jun 29, 2016

jaeilepp deleted the draggable-cmap branch June 30, 2016 05:20


		- Added the ability to decimate :class:`mne.Evoked` objects with :func:`mne.Evoked.decimate` by `Eric Larson`_

		- Add 'cmap=interactive' option to plotting functions by `Jaakko Leppakangas`_

Uh oh!

[MRG+1] Draggable colorbar. #3290

[MRG+1] Draggable colorbar. #3290

Uh oh!

Conversation

jaeilepp commented Jun 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

agramfort Jun 8, 2016

Choose a reason for hiding this comment

Uh oh!

jaeilepp Jun 8, 2016

Choose a reason for hiding this comment

Uh oh!

kingjr commented Jun 8, 2016

Uh oh!

jaeilepp commented Jun 8, 2016

Uh oh!

codecov-io commented Jun 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 86.67%

Uh oh!

kingjr Jun 8, 2016

Choose a reason for hiding this comment

Uh oh!

kingjr commented Jun 8, 2016

Uh oh!

jaeilepp commented Jun 9, 2016

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

larsoner Jun 10, 2016

Choose a reason for hiding this comment

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

jaeilepp commented Jun 10, 2016

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

jaeilepp commented Jun 10, 2016

Uh oh!

jaeilepp commented Jun 10, 2016

Uh oh!

larsoner commented Jun 10, 2016

Uh oh!

jaeilepp commented Jun 14, 2016

Uh oh!

larsoner commented Jun 28, 2016

Uh oh!

dengemann commented Jun 28, 2016

Uh oh!

jaeilepp commented Jun 29, 2016

Uh oh!

agramfort commented Jun 29, 2016

Uh oh!

agramfort commented Jun 29, 2016

Uh oh!

jaeilepp commented Jun 29, 2016

Uh oh!

larsoner commented Jun 29, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jaeilepp commented Jun 8, 2016 •

edited

Loading

codecov-io commented Jun 8, 2016 •

edited

Loading