Fix bug in set_bipolar_reference #3343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mne-tools#3338 There was a test missing for setting multiple references with the `mne.io.set_bipolar_reference` function. With the back and forth on the `Info` object, this case therefore slipped through the regression testing. This PR adds the test and fixes the code.
Member
|
LGTM @klanderson works for you? |
|
@agramfort @wmvanvliet Yeah it works great. Thanks! |
Member
|
thx @wmvanvliet |
jona-sassenhagen
added a commit
to jona-sassenhagen/mne-python
that referenced
this pull request
Jun 27, 2016
* 'master' of git://github.com/mne-tools/mne-python: [MRG] plot_ica_properties (mne-tools#3275) [MRG] Example link (mne-tools#3346) GUI (coregistration): scale step +/- instead of multiplicative (mne-tools#3345) Fix bug in set_bipolar_reference (mne-tools#3343) fixed spelling mistake (mne-tools#3341) Fixed spelling mistake (mne-tools#3339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3338
There was a test missing for setting multiple references with the
mne.io.set_bipolar_referencefunction. With the back and forth on theInfoobject, this case therefore slipped through the regression testing. This PR adds the test and fixes the code.