Skip to content

Conversation

@yarikoptic
Copy link
Contributor

Now it should include msg why actually skipping, e.g.

SKIP: Test test_kit2fiff_model skipped, requires mayavi. Got exception (No module named pyface.tvtk_scene)

Closes #3645

… msg caught exception

RF: no need for helper bool variable -- all handling could be done in try/except
@codecov-io
Copy link

Current coverage is 87.39% (diff: 100%)

Merging #3655 into master will increase coverage by <.01%

@@             master      #3655   diff @@
==========================================
  Files           343        343          
  Lines         60764      60765     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       9301       9300     -1   
==========================================
+ Hits          53107      53108     +1   
  Misses         4903       4903          
  Partials       2754       2754          

Sunburst

Powered by Codecov. Last update 570eab2...b995897

@agramfort
Copy link
Member

@christianbrodbeck can you have a look?

I think it's redundant with your open PR.

thanks @yarikoptic for taking the time to investigate.

@christianbrodbeck
Copy link
Member

Yes #3648 should take care of it eventually, except for the decorator modification.

@agramfort
Copy link
Member

@christianbrodbeck I propose to merge @yarikoptic's PR and that you rebase.

ok for you?

@christianbrodbeck
Copy link
Member

Yes we can do that

@christianbrodbeck christianbrodbeck merged commit 0dd4f75 into mne-tools:master Oct 11, 2016
@christianbrodbeck
Copy link
Member

Thanks @yarikoptic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants