Skip to content

Conversation

@jaeilepp
Copy link
Contributor

cf. mailing list.

Adding a test would require adding a small file which I don't have.

@codecov-io
Copy link

codecov-io commented Aug 30, 2017

Codecov Report

Merging #4520 into master will increase coverage by 0.15%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4520      +/-   ##
==========================================
+ Coverage   83.44%   83.59%   +0.15%     
==========================================
  Files         349      349              
  Lines       65212    65216       +4     
  Branches    10083    10085       +2     
==========================================
+ Hits        54414    54517     +103     
+ Misses       7945     7843     -102     
- Partials     2853     2856       +3

@agramfort
Copy link
Member

Would it be possible to have a test?

Can you update what's new?

@agramfort
Copy link
Member

@jaeilepp did you try on the problematic file ? how do you know it works?

@jaeilepp
Copy link
Contributor Author

jaeilepp commented Sep 4, 2017

Yeah, I have the problematic file. It's 2GB. The event_offset field in the file header was a negative value. Rest of the header seems okay.

@agramfort
Copy link
Member

ok let's say it works then...

@agramfort agramfort merged commit 83e46c4 into mne-tools:master Sep 6, 2017
@agramfort
Copy link
Member

thx @jaeilepp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants