mean fill bug #4521
mean fill bug #4521
Conversation
| rf = ReceptiveField(tmin, tmax, 1, feature_names, fill_mean=True, | ||
| estimator=mod) | ||
| rf.fit(X, y) | ||
| assert_array_equal(rf.delays_, np.arange(tmin, tmax + 1)) |
There was a problem hiding this comment.
This doesn't test that fill_value actually does anything. Can you add a test that fails in master but passes here?
There was a problem hiding this comment.
more over, fill_value is not in ReceptiveField's signature here
There was a problem hiding this comment.
fill_value isn't really meant to be public
There was a problem hiding this comment.
So this is not referring to ReceptiveField's signature?
There was a problem hiding this comment.
Yeah you're right, didn't see it was in __init__ -- it's also not supposed to be publicly exposed, so this is the wrong way to check it
|
@choldgraf do you want me to take over? |
|
@larsoner if you've got the time, please go for it...been at neurohackweek for the last week and my to-do list has exploded as a result :-P |
|
Closing for #4543 |
3 participants
I believe this fixes #4514 and adds a test for it...should double check the tests @larsoner since I wrote this while on a flight back from NYC and my brain was a little fried :-)