FIX: Add numbers for dipoles #4596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengemann
reviewed
Sep 22, 2017
Member
dengemann
left a comment
dengemann
left a comment
There was a problem hiding this comment.
Is this what we now do in ICA?
Member
Author
|
No, in ICA the numbering now starts from 0 for the channel names Updated example |
Member
|
Dipole 51? ... I think a bracket is missing in the code :)
…On Fri, 22 Sep 2017 at 20:08, Eric Larson ***@***.***> wrote:
No, in ICA the numbering now starts from 0 for the channel names
Updated example
https://5853-1301584-gh.circle-artifacts.com/0/tmp/circle-artifacts.klQas8D/html/auto_examples/inverse/plot_mixed_norm_inverse.html
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4596 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB0fitohyqjNkr2XYRICXZnOc40l5qpaks5sk_d2gaJpZM4PhCNV>
.
|
Member
Author
|
I'm not sure what you mean, can you clarify what you want changed? I modified @agramfort's suggestion of doing |
Member
|
Wasn't it 6 before? Did the example change?
…On Fri, 22 Sep 2017 at 20:21, Eric Larson ***@***.***> wrote:
I'm not sure what you mean, can you clarify what you want changed?
I modified @agramfort <https://github.com/agramfort>'s suggestion of
doing Dipole 1 / 7 slightly to be
<https://5853-1301584-gh.circle-artifacts.com/0/tmp/circle-artifacts.klQas8D/html/auto_examples/inverse/plot_mixed_norm_inverse.html> Dipole
#1 / 7 style, in this case it's 51 (index 50
<https://mne-tools.github.io/dev/auto_examples/inverse/plot_mixed_norm_inverse.html#sphx-glr-auto-examples-inverse-plot-mixed-norm-inverse-py>
).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4596 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB0fijdKasTZfU5-G5Q-ohsRiHzXFIVXks5sk_qUgaJpZM4PhCNV>
.
|
Member
Author
|
I have links in my last comment that are before/after this PR. If it changed 6->50 it's not from this PR so let's discuss separately -- any changes you want here? |
Member
|
Ok so if it is 50 on master these changes are ok.
…On Fri, 22 Sep 2017 at 20:42, Eric Larson ***@***.***> wrote:
I have links in my last comment that are before/after this PR. If it
changed 6->50 it's not from this PR so let's discuss separately -- any
changes you want here?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4596 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB0firAX69xtHzmuUXU2KzWzj_mw-1U4ks5sk_-FgaJpZM4PhCNV>
.
|
Codecov Report
@@ Coverage Diff @@
## master #4596 +/- ##
==========================================
+ Coverage 87.04% 87.04% +<.01%
==========================================
Files 349 349
Lines 66030 66030
Branches 10251 10251
==========================================
+ Hits 57476 57477 +1
+ Misses 5661 5660 -1
Partials 2893 2893 |
Member
|
thx @larsoner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takeover of #4431.
Ready for review/merge from my end.