MRG: Fix constants #5691
Merged
MRG: Fix constants #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
larsoner
commented
Nov 2, 2018
| 'dacq_system', 'diffusion_param', 'gantry_type', 'map_surf', | ||
| 'mne_lin_proj', 'mne_ori', 'mri_format', 'mri_pixel', 'proj_by', | ||
| 'tags', 'type', 'iod', 'volume_type', 'vol_type', | ||
| 'coil', # Especially these! 3015, 3025 |
Codecov Report
@@ Coverage Diff @@
## master #5691 +/- ##
==========================================
- Coverage 88.49% 88.34% -0.15%
==========================================
Files 369 369
Lines 69074 69087 +13
Branches 11651 11652 +1
==========================================
- Hits 61124 61037 -87
- Misses 5090 5157 +67
- Partials 2860 2893 +33 |
agramfort
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes various problems with our constants found in #5481. The biggest one was that we were not checking to make sure we had all the constants. We do not, but this makes explicit which ones we don't, and also adds some that we are missing.