-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: 0.18 deprecations #5733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: 0.18 deprecations #5733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5733 +/- ##
==========================================
+ Coverage 88.5% 88.51% +<.01%
==========================================
Files 369 369
Lines 69367 69046 -321
Branches 11689 11638 -51
==========================================
- Hits 61395 61116 -279
+ Misses 5100 5068 -32
+ Partials 2872 2862 -10 |
|
Reviewing this PR is not easy. It would had been better to put everything in an issue and do smaller PRs. We'll know for next time. (I use #5737. Maybe you can add whatever you had in mind #5733 (comment))) |
remove _event_id_func remove _check_trig_shift_by_type as dead-code
remove py2 configparse API
|
I think I'll call it a day. @larsoner feel free to merge when green. |
|
Need to wait until all CIs return |
|
true, it needs to collect all the reports. my bad. |
|
@agramfort feel free to merge if you are happy |
|
awesome ! thanks @larsoner |

This is all of the deprecations for 0.18 except for EDF stim channels. It's not 100% trivial there because of all of the
tal chbusiness, and #5160. We might need to keep thestim_channelparameter there for just that purpose, and say it will only be used for BDF files that actually have a stimulus channel.But let's do that separately. The rest of this is pretty straightforward. I put the auto covariance stuff in a context manager to ensure the the data are always un-scaled (this wasn't ensured before, e.g., if there was an error).