Skip to content

Conversation

@massich
Copy link
Contributor

@massich massich commented Jan 24, 2019

This PR backports #5841.

It mainly adds the same test to show its behaviour, and changes the warning doc.

@massich
Copy link
Contributor Author

massich commented Jan 24, 2019

I'm not quite sure what to do here.

If we call raw = read_raw_edf('test_stim_channel.edf', stim_channel=None)
where 'test_stim_channel.edf' has only 3 channels named: 'status', 'trigger', and 'sine 1 Hz' it tries to something with channel name called 'EDF Annotations' whatever... which seems really wrong.

E           RuntimeWarning: 1 channel names are too long, have been truncated to 15 characters:
E           ['EDF Annotations-1']

This is not the case in master (obviously 'cos the code is completely different).
So I guess the question is: Should we solve all these bugs? or tell people to use 0.18? Or should we just copy paste whatever is in edf.py for version 0.17.1 ?

@agramfort
Copy link
Member

LGTM

thx @massich

@larsoner larsoner mentioned this pull request Jan 24, 2019
6 tasks
@agramfort
Copy link
Member

@larsoner please merge if happy

@larsoner larsoner merged commit 647c7d3 into mne-tools:maint/0.17 Jan 25, 2019
@larsoner
Copy link
Member

Thanks @massich

@massich massich deleted the backport_5841 branch February 14, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants