Fix : simulate evoked with different sensor types + take into account…

[agramfort]

this fixes 2 problems:

• simulate evoked with different sensor types. Symptom was not the noise was not scaled properly for mags. Noise was too strong.
• take into account projs from the cov to make sure that the noise and the signal belong to the same subspace.

thanks @QB3 for the bug report.

[codecov]

Codecov Report

Merging #5940 into master will decrease coverage by 1.82%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5940      +/-   ##
==========================================
- Coverage   88.77%   86.94%   -1.83%     
==========================================
  Files         401      401              
  Lines       72440    72464      +24     
  Branches    12124    12125       +1     
==========================================
- Hits        64305    63002    -1303     
- Misses       5210     6584    +1374     
+ Partials     2925     2878      -47

[massich]

LGTM, I guess that the math checks out (thx @QB3)

ajajajaja, but travis disagree

[massich]

@QB3 this guy is faling

mne-python/mne/beamformer/tests/test_rap_music.py

Line 115 in 12a8549

def test_rap_music_simulated():

run:

pytest mne/beamformer/tests/test_rap_music.py -k test_rap_music_simulated

and if you run this before it will stop where ever it had an error:

export PYTEST_ADDOPTS='--pdb --pdbcls=IPython.terminal.debugger:TerminalPdb --capture no'

then if you whant to stop being blocked by the debugger you can always unset the varaible like this:

unset PYTEST_ADDOPTS

(happy debugging)

[QB3]

I will check this this evening

travis is faling

[larsoner]

Pushed the fix suggested earlier

[larsoner]

@agramfort suggested fix pushed, see simpler more unified code + new test that would have failed with the not-positive-semidef error

[larsoner]

... and reverted a now-unnecessary residual tolerance change in test_dipole.py

[agramfort]

thx heaps @larsoner for finishing this one !

@QB3 you can know switch back to MNE master for your experiments.