MRG: refactor internals for epochs image plot #6186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6186 +/- ##
==========================================
- Coverage 89.01% 88.97% -0.05%
==========================================
Files 410 413 +3
Lines 73894 74236 +342
Branches 12257 12296 +39
==========================================
+ Hits 65776 66048 +272
- Misses 5222 5287 +65
- Partials 2896 2901 +5 |
Contributor
Author
|
Sketch: For epochs.topo_topo, |
Contributor
Author
|
@drammock this too ... |
jona-sassenhagen
changed the title
larsoner
changed the title
jona-sassenhagen
changed the title
Contributor
Author
|
@drammock I have moved epochs objects out of most of the helper functions and made everything a bit more modular. This should now be more conductive to looping over axes and data and calling functions to handle and eventually plot arrays. |
Member
|
But is it MRG????? |
Contributor
Author
|
no :( |
Contributor
Author
|
actually yes |
jona-sassenhagen
changed the title
larsoner
reviewed
Apr 24, 2019
Member
|
Thanks @jona-sassenhagen |
jeythekey
pushed a commit
to jeythekey/mne-python
that referenced
this pull request
Apr 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it easier to handle the unification of topo plotters and single sensor plotters.
@drammock