MRG, BUG: Use testing instead of sample #6490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6490 +/- ##
==========================================
- Coverage 89.24% 89.23% -0.01%
==========================================
Files 413 413
Lines 74528 74528
Branches 12300 12300
==========================================
- Hits 66510 66508 -2
- Misses 5161 5162 +1
- Partials 2857 2858 +1 |
Contributor
|
My bad @larsoner , I'll keep that in mind for now on and thanks for taking care of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #6475 that is breaking Travis in #6489.
FYI @GuillaumeFavelier in tests we should always use the
testingdataset and decorate tests that need the testing data with@testing.requires_testing_data, see changeset here.