Skip to content

Conversation

@drammock
Copy link
Member

@drammock drammock commented Oct 1, 2019

Would benefit from a close read from @agramfort @robertoostenveld and @larsoner, especially the resampling section.

@drammock
Copy link
Member Author

drammock commented Oct 1, 2019

Here is the rendered tutorial

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice !

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #6872 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6872      +/-   ##
==========================================
- Coverage   89.63%   89.61%   -0.02%     
==========================================
  Files         426      426              
  Lines       76037    76037              
  Branches    12402    12402              
==========================================
- Hits        68155    68143      -12     
- Misses       5102     5111       +9     
- Partials     2780     2783       +3

@larsoner larsoner merged commit e78ac34 into mne-tools:master Oct 1, 2019
@larsoner
Copy link
Member

larsoner commented Oct 1, 2019

LGTM so I'll merge. @robertoostenveld feel free to still review and I'm sure @drammock will be happy to make another PR if you find more fixes

@drammock drammock deleted the tut-filt-resamp branch October 1, 2019 23:02
alexrockhill pushed a commit to alexrockhill/mne-python that referenced this pull request Oct 3, 2019
* update filtering & resampling tutorial

* fix codespell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants