MRG, STY: A few tweaks #6999
Merged
MRG, STY: A few tweaks #6999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes that's much nicer. |
agramfort
approved these changes
Oct 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #6999 +/- ##
=========================================
+ Coverage 89.7% 89.7% +<.01%
=========================================
Files 433 433
Lines 77182 77180 -2
Branches 12546 12547 +1
=========================================
Hits 69235 69235
+ Misses 5143 5141 -2
Partials 2804 2804 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small idea I had for DRY/shorter code looking at #6975. @rob-luke do you also prefer it? I find it a little bit cleaner.