-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
TST: Prototype of notebook viz (panel) #7056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Prototype of notebook viz (panel) #7056
Conversation
|
Awesome! Does it work with a multi-view scene, e.g. |
|
Unfortunately, it's disabled for now. The output will just be the output image. Multi-view will be challenging to add I think so I can't say for now but I don't exclude it since |
Codecov Report
@@ Coverage Diff @@
## master #7056 +/- ##
=========================================
Coverage ? 89.73%
=========================================
Files ? 440
Lines ? 77780
Branches ? 12620
=========================================
Hits ? 69796
Misses ? 5174
Partials ? 2810 |
mne/viz/backends/_pyvista.py
Outdated
| def show(self): | ||
| self.figure.display = self.plotter.show() | ||
| self.figure.display = self.plotter.show(use_panel=True, | ||
| auto_close=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this break outside of notebook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my! You're right. I will fix this
|
|
|
This panel example demonstrates multi-view with linked views @larsoner |
|
Awesome! |
|
@GuillaumeFavelier, this is perfect. Nice work! I'd like to have multiple plotting backends supported for Perhaps adding a |
|
Although I agree no backend is perfect, the cost of maintaining this multi-backend architecture plus ensuring the same standard of quality for all of them can be huge in my opinion. I would recommend to stick with the backend with the best coverage of the needed features and then work hard to fill the gap. |
|
The GIF looks great. |
|
Closing now since we got #7758 working |
This PR implements a prototype of integration of the pyvista backend in the jupyter notebook.
Animation:

Static images:





Note: requires the
panelpackage