Skip to content

Conversation

@rob-luke
Copy link
Member

Reference issue

Addresses issue #7057

What does this implement/fix?

Change the way NIRS light frequency is encoded as suggested by @larsoner

@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@67d03cc). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #7064   +/-   ##
=========================================
  Coverage          ?   89.74%           
=========================================
  Files             ?      442           
  Lines             ?    77784           
  Branches          ?    12619           
=========================================
  Hits              ?    69806           
  Misses            ?     5169           
  Partials          ?     2809

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rob-luke this LGTM +1 for merge. I think existing beer-lambert tests should ensure things are working so no need for an updated test. Please set title to MRG if you agree it's good to go and then we'll merge

@rob-luke rob-luke changed the title WIP: Change way NIRS frequency is encoded MRG: Change way NIRS frequency is encoded Nov 15, 2019
@agramfort agramfort merged commit f784fde into mne-tools:master Nov 18, 2019
@agramfort
Copy link
Member

thx @rob-luke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants