-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
VIZ, ENH: Add event dict to epochs plot signature #7126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drammock
merged 6 commits into
mne-tools:master
from
drammock:add-event-dict-to-epochs-plot-signature
Dec 9, 2019
Merged
VIZ, ENH: Add event dict to epochs plot signature #7126
drammock
merged 6 commits into
mne-tools:master
from
drammock:add-event-dict-to-epochs-plot-signature
Dec 9, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Dec 7, 2019
Member
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for MRG provided CIs are green. Add a what's new entry before merging plz
thx
larsoner
reviewed
Dec 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #7126 +/- ##
==========================================
+ Coverage 89.48% 89.73% +0.25%
==========================================
Files 444 444
Lines 79002 79138 +136
Branches 12678 12692 +14
==========================================
+ Hits 70696 71017 +321
+ Misses 5456 5314 -142
+ Partials 2850 2807 -43 |
mention versionadded Co-Authored-By: Eric Larson <larson.eric.d@gmail.com>
agramfort
approved these changes
Dec 9, 2019
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* add event_id dict to epochs.plot() signature * update tutorial to test it * add tutorial explanation * event line at t=0 (possibly w/ user-specified color) overrides green t=0 line * update what's new * Update mne/viz/epochs.py mention versionadded Co-Authored-By: Eric Larson <larson.eric.d@gmail.com>
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* add event_id dict to epochs.plot() signature * update tutorial to test it * add tutorial explanation * event line at t=0 (possibly w/ user-specified color) overrides green t=0 line * update what's new * Update mne/viz/epochs.py mention versionadded Co-Authored-By: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #7111, this adds an
event_idparameter toepochs.plot()so that if users are passing ineventsthat aren't part ofepochs.events, they can specify event colors by name instead of by integer.It also allows user-specified event colors for the t=0 event to override the (default) transparent green vertical line at t=0. On this PR:
yields this:
If no events are specified, or if the events passed to
plot()don't include the event at t=0, the default line is still drawn (though it's been moved to zorder=0 to lie behind the traces instead of on top of them):