MRG: Use latest version 0.23.0 of pyvista instead of master

[GuillaumeFavelier]

This PR updates the package requirements for the pyvista 3d backend.

[larsoner]

To save us some potential post-merge pain, can you push a commit with [circle full] in the message so we can make sure everything works before merging?

[codecov]

Codecov Report

Merging #7150 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #7150      +/-   ##
==========================================
+ Coverage   89.75%   89.75%   +<.01%     
==========================================
  Files         444      444              
  Lines       79312    79328      +16     
  Branches    12681    12685       +4     
==========================================
+ Hits        71185    71201      +16     
  Misses       5344     5344              
  Partials     2783     2783

[GuillaumeFavelier]

I've bult the doc locally with MNE_3D_BACKEND=pyvista make html_dev but I can't reproduce Circle issue:

...
generating gallery for auto_examples/connectivity... [ 55%] plot_mne_inverse_envelope_correlation.py
Makefile:44: recipe for target 'html_dev' failed
make: *** [html_dev] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded

[GuillaumeFavelier]

The merge with master didn't solve this one.

[GuillaumeFavelier]

This time Circle failed with:

...
generating gallery for auto_examples/connectivity... [ 22%] plot_mixed_source_space_connectivity.py
Makefile:44: recipe for target 'html_dev' failed
make: *** [html_dev] Terminated

Too long with no output (exceeded 10m0s): context deadline exceeded

[GuillaumeFavelier]

But Travis is happy now

[agramfort]

I've tried to restart the build.

@GuillaumeFavelier can you do a test of mprof on the example that fails?

[GuillaumeFavelier]

Circle displays the current script or the last script executed with success? Because I don't think plot_mixed_source_space_connectivity.py uses the pyvista 3d backend.

[GuillaumeFavelier]

Everything seems fine on the previous version.

Azure has a http error: http.client.IncompleteRead: IncompleteRead(319488 bytes read)

[GuillaumeFavelier]

Result available here: https://17262-1301584-gh.circle-artifacts.com/0/dev/index.html

[agramfort]

so we have a regression with pyvista 0.23 :(

…

[GuillaumeFavelier]

After investing some [circle full] time, my guess is that the regression is related to pyvista/pyvista@5b5a09d. At least, I can say that everything works fine until this one. This work introduces auto_update=True to the BackgroundPlotter and QtInteractor.

Let's go back on pyvista==0.23.0 and try again with auto_update=False.

[GuillaumeFavelier]

The results are available: https://17307-1301584-gh.circle-artifacts.com/0/dev/index.html

AFAIK, pyvista/pyvista#509 (comment) helps for embedding a plotter as a qt widget, this is not something we're interested in here so keeping auto_update=False is fine by me.

I think this PR is ready for reviews now @agramfort, @larsoner

[larsoner]

LGTM +1 for merge once CircleCI is happy

[agramfort]

Awesome Thx @GuillaumeFavelier