FIX: Fix actor getting fetched from hemi data #7226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86 tasks
larsoner
approved these changes
Jan 17, 2020
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
LGTM and works well here, +1 for merge
Codecov Report
@@ Coverage Diff @@
## master #7226 +/- ##
==========================================
+ Coverage 89.76% 89.77% +<.01%
==========================================
Files 445 445
Lines 80127 80127
Branches 12817 12817
==========================================
+ Hits 71925 71932 +7
+ Misses 5385 5378 -7
Partials 2817 2817 |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #7219, the API to fetch hemi data has changed in
_Brain. The result is that although the values for theauto-scalingare correct, the colorbar is not changed. This PR updates the old method used inupdate_auto_scaling().