Skip to content

Conversation

@larsoner
Copy link
Member

I noticed in https://travis-ci.org/mne-tools/mne-python/jobs/650978029?utm_medium=notification&utm_source=github_status that a lot of time was spent in:

115.44s call     mne/inverse_sparse/tests/test_mxne_inverse.py::test_mxne_inverse_standard

Profiling suggests that about half the time was spent in convert_forward_solution, and a lot of that was in _normal_orth, so this might be a speed regression due to #7290.

In any case, this PR takes that test from 23 sec to 14 sec on my system. Timings for mne/tests/test_chpi.py don't change, so the n-dim generalization that this makes use of seems to be not so painful for the single vector case.

@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #7333 into master will decrease coverage by 1.87%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #7333      +/-   ##
=========================================
- Coverage   89.88%     88%   -1.88%     
=========================================
  Files         450     450              
  Lines       81264   81264              
  Branches    12918   12918              
=========================================
- Hits        73046   71520    -1526     
- Misses       5396    6981    +1585     
+ Partials     2822    2763      -59

@larsoner
Copy link
Member Author

I think ultimately we are suffering from numpy/numpy#15580, but this should still be merged since it's useful in any case

@larsoner
Copy link
Member Author

(and the failures are fixed by #7325, even if the timeouts are not)

@larsoner larsoner merged commit d9e729f into mne-tools:master Feb 17, 2020
@larsoner larsoner deleted the normal_orth branch February 17, 2020 01:21
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
* ENH: Speed up convert_forward_solution

* FIX: Use eigh

* FIX: Limit

* FIX: Flake

* MAINT: Show NumPy config
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
* ENH: Speed up convert_forward_solution

* FIX: Use eigh

* FIX: Limit

* FIX: Flake

* MAINT: Show NumPy config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants