MRG, ENH: Speed up convert_forward_solution #7333
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in https://travis-ci.org/mne-tools/mne-python/jobs/650978029?utm_medium=notification&utm_source=github_status that a lot of time was spent in:
Profiling suggests that about half the time was spent in
convert_forward_solution, and a lot of that was in_normal_orth, so this might be a speed regression due to #7290.In any case, this PR takes that test from 23 sec to 14 sec on my system. Timings for
mne/tests/test_chpi.pydon't change, so the n-dim generalization that this makes use of seems to be not so painful for the single vector case.