Skip to content

MRG: Use the renderer fixture in test_mixed_sources_plot_surface #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GuillaumeFavelier merged 1 commit into from
Mar 16, 2020
Merged

MRG: Use the renderer fixture in test_mixed_sources_plot_surface #7454

GuillaumeFavelier merged 1 commit into from
Mar 16, 2020

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 16, 2020 •
edited
Loading

This short PR follows the tests on #7294 and modifies test_mixed_sources_plot_surface to use the renderer fixture. I also removed garbage_collect according to #7294 (comment) advice

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 16, 2020
agramfort
agramfort approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when green

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #7454 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7454      +/-   ##
==========================================
+ Coverage   90.07%   90.13%   +0.06%     
==========================================
  Files         454      454              
  Lines       82353    81535     -818     
  Branches    13016    13015       -1     
==========================================
- Hits        74180    73493     -687     
+ Misses       5350     5210     -140     
- Partials     2823     2832       +9

@GuillaumeFavelier GuillaumeFavelier changed the title Use the renderer fixture in test_mixed_sources_plot_surface MRG: Use the renderer fixture in test_mixed_sources_plot_surface Mar 16, 2020
@GuillaumeFavelier GuillaumeFavelier merged commit fd5a8c5 into mne-tools:master Mar 16, 2020
@GuillaumeFavelier GuillaumeFavelier deleted the test_mixed_plot_renderer_fixture branch June 11, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agramfort agramfort agramfort approved these changes

Assignees

@GuillaumeFavelier GuillaumeFavelier

Labels

VIZ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuillaumeFavelier @agramfort