Use _time_interp_funcs in _interpolate_data #7462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you touch at least one of the broken examples so that we can verify the fix? |
Codecov Report
@@ Coverage Diff @@
## master #7462 +/- ##
==========================================
- Coverage 90.05% 87.61% -2.45%
==========================================
Files 454 454
Lines 82523 82558 +35
Branches 13043 13050 +7
==========================================
- Hits 74320 72331 -1989
- Misses 5367 7425 +2058
+ Partials 2836 2802 -34 |
Member
|
CircleCI is fixed so I'll merge. It looks like something else has broken most of our other CIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the recent issues with Circle. For short,
_interpolate_data()now uses_time_interp_funcsReference: #7257 (comment)