MRG: Configure _TimeViewer status bar #7588
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7588 +/- ##
==========================================
- Coverage 90.12% 90.12% -0.01%
==========================================
Files 454 454
Lines 83392 83401 +9
Branches 13210 13210
==========================================
+ Hits 75159 75161 +2
- Misses 5374 5378 +4
- Partials 2859 2862 +3 |
|
@hoechenberger does it fix the last bit of jerkiness in the interface? Also feel free to share if you have any idea on how to populate the status bar 👍 |
|
@GuillaumeFavelier There is a small glitch visible in the status bar once the help text gets removed. The glitch disappears as soon as I resize the window, so it's most likely just a tiny redrawing issue? (lower left corner of the window) |
Will do later :) |
|
Thanks for sharing the video! you got 1 more like.
Probably, I will investigate. |
🤣👍 |
GuillaumeFavelier
changed the title
|
I switched the message to the internal |
GuillaumeFavelier
changed the title
|
(Just chatted with @GuillaumeFavelier; the graphical glitch is gone for me, and I suggested to remove the |
GuillaumeFavelier
changed the title
GuillaumeFavelier
changed the title
| def configure_status_bar(self): | ||
| from PyQt5.QtWidgets import QLabel, QProgressBar | ||
| self.status_msg = QLabel(self.default_status_bar_msg) | ||
| self.status_progress = QProgressBar() |
There was a problem hiding this comment.
The progress bar is currently unused, right? Are you planning on reviving it (+1 on that btw!), or why is it here? :)
There was a problem hiding this comment.
The progress bar is currently unused so it is hidden. But I add it in here because I plan to use it when I will add support for save_movie in _TimeViewer. It's an item of #7162
There was a problem hiding this comment.
Thanks for the clarification. Just wanted to ensure you didn't accidentally leave sth in that you don't need anymore.
|
@larsoner One of the Azure builds failed because it was somehow canceled (for whatever reason). Would it be possible for me to restart such CI runs somehow? It seems I'm currently lacking the required permissions? |
3 participants
This PR brings back the part of #7257 about the configuration of the status bar. By default it displays a help message for 5 seconds and adds basic support for a progress bar. It's also a follow-up to #7580 (comment).