MRG: Refactor _TimeViewer shortcuts #7610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
approved these changes
Apr 16, 2020
Member
hoechenberger
left a comment
hoechenberger
left a comment
There was a problem hiding this comment.
Works like a charm for me!
Contributor
Author
|
I have to update |
GuillaumeFavelier
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7610 +/- ##
==========================================
+ Coverage 90.03% 90.12% +0.09%
==========================================
Files 454 454
Lines 83400 83401 +1
Branches 13210 13209 -1
==========================================
+ Hits 75093 75169 +76
+ Misses 5427 5373 -54
+ Partials 2880 2859 -21 |
GuillaumeFavelier
changed the title
Member
|
Thanks @GuillaumeFavelier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #7589 we can now drastically simplify the way we manage the shortcuts in
_TimeViewer. This PR also improves stability because we don't rely on thekeyPressEventcallback anymore and flexibility because we useQActioninstead of adictfor the bindings. It's also easier to maintain because the shortcuts are set in one place.