-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: Add example of projection to source space #7705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The way it’s coded here you add back the mean (via inverting scaler) which gives you essentially the grand average ERF. |
|
It seems weird to add in this manual step. Isn't it informative to start to know that it is basically making use of the grand average ERF to do the classification, even if it does some processing like mean subtraction and standardization, PCA, whatever else, along the way? |
|
But the model uses the de-meaned data. You essentially add back the intercept which will suffocate the model specific-patterns. |
|
Here I just make use of an existing |
|
Yeah it’s an old issue just seeing that brings it back to memory.
I think we should make these considerations part of the tutorial and explore the different outputs.
… On 30 Apr 2020, at 19:44, Eric Larson ***@***.***> wrote:
Here I just make use of an existing evoked_time_gen that's already part of the narrative. So if we're going to make that change, it's actually orthogonal to this one (should be separate PR). Can you make a PR to improve this part of the tutorial and make evoked_time_gen more informative in this regard?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Codecov Report
@@ Coverage Diff @@
## master #7705 +/- ##
==========================================
- Coverage 90.35% 90.30% -0.06%
==========================================
Files 455 455
Lines 84419 84561 +142
Branches 13369 13396 +27
==========================================
+ Hits 76274 76360 +86
- Misses 5273 5318 +45
- Partials 2872 2883 +11 |
|
Updated doc: It seems to look wacky because we are getting "403 (Forbidden)" errors when downloading bootstrap JS, it's doing that on other PRs, too. |
|
Thanks, @larsoner, and @dengemann. I think we need to discuss this in detail. |
* upstream/master: DOC: Order added reference FIX: Working working version ENH: More efficient actually working csd, needs review MAINT: Update dataset and add constant test (mne-tools#7866) DOC: update link to glasser supplementary info; convert to footbib (mne-tools#7864) FIX: Fix subtract_evoked with decim (mne-tools#7855) FIX: Fix reading of old TFRs (mne-tools#7851) DOC: Add evoked movecomp to example (mne-tools#7852) Deprecate meg=True in pick_types (mne-tools#7823) ENH: Allow reading broken file (mne-tools#7846) MRG, ENH: Add mixed source estimate support to compute_source_morph (mne-tools#7734) FIX: Fix bug with metadata and event_repeated (mne-tools#7733) MRG, ENH: Add axes to plot_evoked_white (mne-tools#7831) MRG, ENH: Add example of projection to source space (mne-tools#7705)
@SherazKhan asked if we had an example of projecting decoder coefficients to source space yet and I didn't think we did. This adds it to the decoding tutorial, and cleans up some refs to use the new footbib magic.